-
Notifications
You must be signed in to change notification settings - Fork 6.1k
8358679: [asan] vmTestbase/nsk/jvmti tests show memory issues #26176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Welcome back amenkov! A progress list of the required criteria for merging this PR into |
@alexmenkov This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be:
You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been 23 new commits pushed to the
As there are no conflicts, your changes will automatically be rebased on top of these commits when integrating. If you prefer to avoid this automatic rebasing, please check the documentation for the /integrate command for further details. ➡️ To integrate this PR with the above commit message to the |
@alexmenkov The following label will be automatically applied to this pull request:
When this pull request is ready to be reviewed, an "RFR" email will be sent to the corresponding mailing list. If you would like to change these labels, use the /label pull request command. |
Webrevs
|
test/hotspot/jtreg/vmTestbase/nsk/jvmti/RawMonitorEnter/rawmonenter003/TestDescription.java
Outdated
Show resolved
Hide resolved
…enter003/TestDescription.java Co-authored-by: Chris Plummer <chris.plummer@oracle.com>
The fix updates several tests ASAN complains about.
Tests for RawMonitors intentionally passes bad pointer to tested function, they should not be run with ASAN.
Test vmTestbase/nsk/jvmti/scenarios/events/EM07/em07t002 verifies COMPILED_METHOD_LOAD/COMPILED_METHOD_UNLOAD event and uses RawMonitor for synchronization. It destroys the monitor, but some events may arrive later (before VM exits). Usually JVMTI tests do not destroy synchronization monitors, removed destruction here.
Progress
Issue
Reviewers
Reviewing
Using
git
Checkout this PR locally:
$ git fetch https://git.openjdk.org/jdk.git pull/26176/head:pull/26176
$ git checkout pull/26176
Update a local copy of the PR:
$ git checkout pull/26176
$ git pull https://git.openjdk.org/jdk.git pull/26176/head
Using Skara CLI tools
Checkout this PR locally:
$ git pr checkout 26176
View PR using the GUI difftool:
$ git pr show -t 26176
Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jdk/pull/26176.diff
Using Webrev
Link to Webrev Comment